Allow Skunk to generate reports in a given path with the --out flag#131
Draft
JuanVqz wants to merge 3 commits intofeat/cli-multi-out-formatsfrom
Draft
Allow Skunk to generate reports in a given path with the --out flag#131JuanVqz wants to merge 3 commits intofeat/cli-multi-out-formatsfrom
--out flag#131JuanVqz wants to merge 3 commits intofeat/cli-multi-out-formatsfrom
Conversation
…rinting Move output path configuration to Skunk::Config and remove file output logic from Application#print Update tests and documentation to reflect changes in output path handling Even if the default path where the JSON and HTML reports are generated are `tmp/rubycritic` you can now modify them.
Skunk_report (txt,json,html)
JuanVqz
force-pushed
the
feat/cli-out-path-root
branch
from
65f04b5 to
1411dcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is a breaking change, because the
--outflag used to add afilenameto save theconsolereport, and now this is accepting the path where reports are going to be saved, (not the file name).Following
RubyCriticconventions, we are setting therootattribute where the reports will be stored; by default it istmp/rubycritic(we can change it totmp/skunkas part of this PR).CHANGELOG.mdthat links to this PR under the "main (unreleased)" heading.I will abide by the.